Merged
Conversation
Contributor
Author
|
This took quite a long time to do. So possible a type-hint is incorrect. But usually we will catch those as we complete all the type-hints. I think everything is correct, but no guarantees 🙂 |
Added type-hints to: * `response_lexer.py` * `response_parser.py` * `response_types.py`
JohnVillalovos
force-pushed
the
jlvillal/mypy_1
branch
from
0157187 to
e8bcae8
Compare
mjs
approved these changes
Aug 27, 2023
Owner
mjs
left a comment
mjs
left a comment
There was a problem hiding this comment.
This looks great. As you said, we'll catch any typing errors as more of the code gets hints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added type-hints to:
response_lexer.pyresponse_parser.pyresponse_types.py