Skip to content

fix: broken get() & getboolean()#486

Merged
mjs merged 2 commits intomjs:masterfrom
JohnVillalovos:jlvillal/fix_issue
Jul 18, 2022
Merged

fix: broken get() & getboolean()#486
mjs merged 2 commits intomjs:masterfrom
JohnVillalovos:jlvillal/fix_issue

Conversation

@JohnVillalovos
Copy link
Contributor

@JohnVillalovos JohnVillalovos commented Jul 10, 2022

Commit 92255e9 introduced a bug by
adding section to the argument list, but the callers don't send
section.

Fix this by removing section from the argument list.

Commit 6e6ec34 removed the
tests/utils.py file but missed updating livetest.py

Import unittest directly from livetest.py

Discovered while working on adding mypy testing.

Commit 92255e9 introduced a bug by
adding `section` to the argument list, but the callers don't send
`section`.

Fix this by removing `section` from the argument list.
Commit 6e6ec34 removed the
`tests/utils.py` file but missed updating `livetest.py`

Import `unittest` directly from `livetest.py`

Discovered while working on adding `mypy` testing.
Copy link
Owner

@mjs mjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for catching this

@mjs mjs merged commit e6c8cb0 into mjs:master Jul 18, 2022
@JohnVillalovos JohnVillalovos deleted the jlvillal/fix_issue branch September 27, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants