Merged
Conversation
Collaborator
|
Could we put all the dependencies in a |
mjs
reviewed
Jun 23, 2022
Owner
mjs
left a comment
mjs
left a comment
There was a problem hiding this comment.
This looks great aside from the concern Nicolas raised.
Thanks very much!
Commit f072340 ran `black` on the code base. But since it wasn't being enforced in the CI, it has drifted away from `black` standarized formatting. Did the following: * Added a Github CI job to run `black` * Added a `black` tox environment * Ran `black` on the code * Added the `requirements-dev.txt` file This has been setup so that it should be easy to add other checkers/linters in the future as desired.
JohnVillalovos
force-pushed
the
jlvillal/black_todo
branch
from
ae090e0 to
65409e1
Compare
Contributor
Author
Done! 😊 |
Collaborator
|
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit f072340 ran
blackon thecode base. But since it wasn't being enforced in the CI, it has
drifted away from
blackstandarized formatting.Did the following:
blackblacktox environmentblackon the coderequirements-dev.txtfileThis has been setup so that it should be easy to add other
checkers/linters in the future as desired.