Clarify source build docs for qt6 branch and cmake compat #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit build instructions for the recommended qt6 branch with the correct git clone command (-b qt6), document the CMAKE_POLICY_VERSION_MINIMUM workaround for cmake 4.0+ compatibility with older submodules like eglut, and clearly separate the deprecated main branch instructions from the recommended qt6 path. Addresses minecraft-linux#120 Co-Authored-By: Claude Opus 4.6 <[email protected]>
src/source_build/launcher.md
Outdated
| <div class="warning"> | ||
|
|
||
| The qt5 version is deprecated and only supported on distributions with protobuf that not depends on abseil and uses cmake 3.x. | ||
| The default (main) branch uses Qt5 and is deprecated. It is only supported on distributions with protobuf that does not depend on abseil and that use cmake 3.x. |
Member
There was a problem hiding this comment.
our default branch is called ng
- Default branch of mcpelauncher-manifest is 'ng', not 'main' - Remove cmake 4.0 support claims from qt6 branch (never completed) - Remove cmake policy workaround note (not applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
qt6branch, including the correctgit clone -b qt6command-DCMAKE_POLICY_VERSION_MINIMUM=3.5workaround for cmake 4.0+ users encountering policy errors from older submodules (e.g. eglut)Addresses #120
Context
As reported in #120, the source build guide previously only showed how to clone the default (main/Qt5) branch, which is deprecated. The warning box mentioned the qt6 branch but didn't explain how to actually use it. Users building from source with cmake 4.0+ would also encounter cmake policy version conflicts from submodules like eglut that specify cmake 3.5, with no guidance on how to resolve them.
Test plan
#building-the-qt6-branch-recommended) resolves correctly in the rendered mdbook outputgit clone --recursive -b qt6correctly pulls the qt6 branch with submodules