RP2350 (Pico 2) support and fix BPM-too-slow problem on RP2040/RP2350#64
Open
doctea wants to merge 4 commits intomidilab:mainfrom
Open
RP2350 (Pico 2) support and fix BPM-too-slow problem on RP2040/RP2350#64doctea wants to merge 4 commits intomidilab:mainfrom
doctea wants to merge 4 commits intomidilab:mainfrom
Conversation
Contributor
Author
|
This also now solves long-standing problem with BPM being a little too slow. Should now be perfectly accurate! Problem was needing to cast interval from uint32_t to int32_t so that the correct negative interval is passed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very simple patch, its the same as for RP2040, just needed to update the #ifdef check to check for
ARDUINO_ARCH_RP2350in addition toARDUINO_ARCH_RP2040:)