Heal tracking database if it can't open#5724
Merged
JohnMcPMS merged 2 commits intomicrosoft:masterfrom Sep 22, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
dkbennett
approved these changes
Sep 21, 2025
| // Move existing database and create a new one | ||
| std::filesystem::path destination{ trackingDB }; | ||
| destination.replace_filename(c_PackageTrackingCorruptedFileName); | ||
| SQLite::SQLiteStorageBase::RenameSQLiteDatabase(trackingDB, destination, true); |
Member
There was a problem hiding this comment.
Is there a goal to eventually try to fix or recover some data from corrupted databases?
Member
Author
There was a problem hiding this comment.
Certainly not programmatically, as the issue here is that SQLite could not open the file as a database (making it quite difficult to operate on) or that we are missing the table that contains the schema version. The goal of the rename is to allow for human investigation if needed rather than removing any trace of the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
When we fail to open the tracking database, rename it and create a new one. The initial
Openrequires two things to succeed:If an exception is thrown, we move the file (and the auxiliary journals if they exist) to new names (
installed.db->installed-corrupted.db) and create a new database.Validation
Added a unit test that corrupts the database and is able to open the new one.
Microsoft Reviewers: Open in CodeFlow