Centralize all configuration strings into settingKeys.ts
#4577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexr00
previously approved these changes
Mar 29, 2023
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Looks good, thank you! I will merge after the release tomorrow.
aeschli
previously approved these changes
Apr 11, 2023
Makes it eaiser to keep track of how/where configuration is being used.
auto-merge was automatically disabled
April 11, 2023 13:56
Head branch was pushed to by a user without write access
Member
|
@kabel when making changes to a PR please merge main into your topic branch instead of force pushing. I now can't see what I've already reviewed and I need to review the whole PR again. |
Contributor
Author
Sure. Force of habit from dealing with repositories that prefer PRs to maintain linear history. |
mjbvz
approved these changes
Apr 19, 2023
alexr00
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it eaiser to keep track of how/where configuration is being used.