Skip to content

Conversation

@ssreerama
Copy link
Contributor

Pull Request Template – vscode-mssql

Issue: #20388

Description

When users add to their .sqlproj files, the SqlToolsService backend returns both the glob pattern itself and the expanded file paths. This caused the literal pattern "queries/**" to appear as a clickable but non-existent file in the project tree.

Changes:

  • Filter out paths containing glob wildcards (*, ?, [ )
  • Add test case validating glob patterns are excluded from noneDeployScripts
  • Update baseline to include examples of all MSBuild glob pattern types:
    • Recursive wildcard (**)
    • Single character wildcard (?)
    • Character set ([abc])
    • Character range ([a-z])
    • Negation ([!_])

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Before Fix:
image
image

After Fix:
image

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5289 KB 5289 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 5668 KB 5669 KB ⚪ 1 KB ( 0% )
data-workspace VSIX null KB 542 KB ⚪ 542 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.64%. Comparing base (2741a03) to head (28bc41a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #20883   +/-   ##
=======================================
  Coverage   66.64%   66.64%           
=======================================
  Files         210      210           
  Lines       20277    20277           
  Branches     2639     2639           
=======================================
  Hits        13514    13514           
  Misses       6666     6666           
  Partials       97       97           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants