Skip to content

line and offset are 0 based in corsa #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iisaduan merged 2 commits into from
Apr 14, 2026
Merged

line and offset are 0 based in corsa #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
321c5a0
line and offset are 0 based in corsa
iisaduan Apr 13, 2026
7b0f8cc
rename param display name
iisaduan Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ parameters:
type: string
default: 'any,ts-perf1,ts-perf2,ts-perf3,ts-perf4,ts-perf5,ts-perf6,ts-perf7,ts-perf8,ts-perf9,ts-perf10,ts-perf11,ts-perf12'
- name: TS_GO
displayName: boolean to describe if building ts-go
displayName: building ts-go
type: boolean
default: false

Expand Down
8 changes: 4 additions & 4 deletions ts-perf/packages/commands/src/benchmark/measurelsp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,8 @@ async function runPerf(options: CLIOpts) {
await connection.sendRequest(protocol.ReferencesRequest.method, {
textDocument: { uri: fileUri },
position: {
line: command.args.line,
character: command.args.offset,
line: command.args.line - 1,
character: command.args.offset - 1,
},
context: { includeDeclaration: true },
} as protocol.ReferenceParams);
Expand All @@ -307,8 +307,8 @@ async function runPerf(options: CLIOpts) {
{
textDocument: { uri: fileUri },
position: {
line: command.args.line,
character: command.args.offset,
line: command.args.line - 1,
character: command.args.offset - 1,
},
} as protocol.CompletionParams,
);
Expand Down
Loading