Skip to content

Fix "Lable" misspelling in Make2023BootableMedia.ps1 #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flickdm merged 11 commits into from
Jun 26, 2025
Merged

Fix "Lable" misspelling in Make2023BootableMedia.ps1 #221

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fdf6a2f
Fix spelling errors: ISO_Lable → ISO_Label and other typos
Copilot Jun 13, 2025
91c1bd0
Add comprehensive test scripts for PowerShell spelling corrections va…
Copilot Jun 13, 2025
dc22012
Add PR gate workflow to validate Make2023BootableMedia.ps1 changes
Copilot Jun 13, 2025
d86b55d
Fix GitHub action to properly fail when tests fail and improve script…
Copilot Jun 13, 2025
46fda86
Add missing newlines at end of workflow and test files
Copilot Jun 13, 2025
35ffb73
Merge branch 'main' into copilot/fix-220
Flickdm Jun 16, 2025
7a3c8e8
Merge branch 'main' into copilot/fix-220
Flickdm Jun 16, 2025
2c1db8c
Merge branch 'main' into copilot/fix-220
Flickdm Jun 16, 2025
36e0358
Merge branch 'main' into copilot/fix-220
Flickdm Jun 26, 2025
f9ee4e4
Remove redundant 'Report test results' step from workflow
Copilot Jun 26, 2025
f78a80c
Remove PR gate workflow and test files as requested
Copilot Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions scripts/windows/Make2023BootableMedia.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function Show-Usage {
}

function Show-ADK-Req {
Write-Host "This script requires the Windows ADK be installed on the system. Avalable at http://aka.ms/adk" -ForegroundColor Red
Write-Host "This script requires the Windows ADK be installed on the system. Available at http://aka.ms/adk" -ForegroundColor Red
Write-Host "After install, open an admin-elevated 'Deploy and Imaging Tools Environment' command prompt provided with the ADK." -ForegroundColor Red
Write-Host "Then run PowerShell from this command prompt and you should be good to go.`r`n" -ForegroundColor Red
}
Expand Down Expand Up @@ -227,7 +227,7 @@ function Initialize-MediaPaths {
$localMediaPath = ($mountResult | Get-Volume).DriveLetter + ":"

# Retrieve the volume label from the mounted ISO to be used later if a new ISO is created
$global:ISO_Lable = (Get-Volume -DriveLetter ($mountResult | Get-Volume).DriveLetter).FileSystemLabel
$global:ISO_Label = (Get-Volume -DriveLetter ($mountResult | Get-Volume).DriveLetter).FileSystemLabel

} else {

Expand Down Expand Up @@ -714,15 +714,15 @@ function Create-ISOMedia {

Write-Host "Writing 'Windows UEFI CA 2023' bootable ISO media at location [$ISOPath]" -ForegroundColor Blue

# If $ISOLable is not set, then defualt to "WINDOWS2023PCAISO"
if (-not $global:ISO_Lable) {
$global:ISO_Lable = "WINDOWS2023PCAISO"
# If $ISOLabel is not set, then default to "WINDOWS2023PCAISO"
if (-not $global:ISO_Label) {
$global:ISO_Label = "WINDOWS2023PCAISO"
}

# Generate a timestamp string in the following format: mm/dd/yyyy,hh:mm:ss
$timestamp = Get-Date -Format "MM/dd/yyyy,HH:mm:ss"

$runCommand = "-l$global:ISO_Lable -t$timestamp -bootdata:2#p0,e,b$global:Temp_Media_To_Update_Path\boot\etfsboot.com#pEF,e,b$global:Temp_Media_To_Update_Path\efi\microsoft\boot\efisys_ex.bin -u2 -udfver102 -o $global:Temp_Media_To_Update_Path `"$($ISOPath)`""
$runCommand = "-l$global:ISO_Label -t$timestamp -bootdata:2#p0,e,b$global:Temp_Media_To_Update_Path\boot\etfsboot.com#pEF,e,b$global:Temp_Media_To_Update_Path\efi\microsoft\boot\efisys_ex.bin -u2 -udfver102 -o $global:Temp_Media_To_Update_Path `"$($ISOPath)`""

Write-Dbg-Host "Running: $global:oscdimg_exe $runCommand"
try {
Expand Down