Skip to content

Update templates#199

Merged
Flickdm merged 3 commits intomicrosoft:mainfrom
Flickdm:update/templates
May 2, 2025
Merged

Update templates#199
Flickdm merged 3 commits intomicrosoft:mainfrom
Flickdm:update/templates

Conversation

@Flickdm
Copy link
Member

@Flickdm Flickdm commented Apr 28, 2025

Description

Resolves feedback in issue #198.

The renaming will be a breaking change however since the release has not been made yet and includes additional breaking changes - now is the correct time to make this change.

  1. This PR renames the variables to remove "Default"
  2. Add's additional "Most Compatible" template
  3. Add's a notice to the "MicrosoftAndOptionRoms.toml" indicating that the template is not yet recommended due to lack of saturation in the ecosystem for the Option ROM CA signing.
  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Local Machine

Integration Instructions

Renaming the "Default.bin" to ".bin"

@Flickdm Flickdm requested review from Copilot and spbrogan April 28, 2025 19:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses issue #198 by renaming configuration variables to remove the "Default" prefix, adds a new "Most Compatible" template, and updates the Option ROM template with a notice regarding its production suitability.

  • Renames sections from DefaultPk/DefaultKek/DefaultDb/DefaultDbx to PK/KEK/DB/DBX in multiple template files
  • Introduces a new "Most Compatible – Microsoft and 3rd Party" template
  • Updates the Option ROM template with a production recommendation notice and adjusts the workflow configuration accordingly

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
Templates/MostCompatible.toml Adds a new template for a most-compatible configuration
Templates/MicrosoftAndThirdParty.toml Renames configuration sections to remove the "Default" prefix and updates help text
Templates/MicrosoftAndOptionRoms.toml Updates the template header notice and renames configuration sections appropriately
.github/workflows/prepare-binaries.yml Updates workflow to refer to the new MicrosoftAndThirdParty.toml template
Files not reviewed (1)
  • scripts/windows/InstallSecureBootKeys.ps1: Language not supported
Comments suppressed due to low confidence (2)

Templates/MicrosoftAndOptionRoms.toml:2

  • [nitpick] The template header name appears inconsistent with the file name 'MicrosoftAndOptionRoms.toml' and its intended Option ROM usage. Consider revising the template name to better reflect its purpose.
# Template Name: Secure Desktop – Microsoft Only

Templates/MicrosoftAndThirdParty.toml:39

  • [nitpick] The help text references 'MicrosoftOnlyDefaults', which is inconsistent with the new naming convention. Updating this description for clarity would improve consistency.
help = "Contains 2023 Microsoft and UEFI third party certificates to verify binaries before execution. More compatible than MicrosoftOnlyDefaults."

@Flickdm Flickdm requested a review from Javagedes April 29, 2025 19:22
@Flickdm Flickdm force-pushed the update/templates branch 2 times, most recently from 3cba23f to 937fc42 Compare May 1, 2025 17:03
@Flickdm Flickdm enabled auto-merge (rebase) May 2, 2025 18:20
@Flickdm Flickdm force-pushed the update/templates branch from 937fc42 to 29689df Compare May 2, 2025 18:20
@Flickdm Flickdm merged commit 277dfbf into microsoft:main May 2, 2025
2 checks passed
@Flickdm Flickdm deleted the update/templates branch May 2, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments