Add support for React Native's maxFontSizeMultiplier Text prop #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@sbeca -- I know this PR has lingered a little bit since you made it, are there any additional tweaks you want to make before I review this? I'm looking to make a release in Early September! |
Contributor
Author
|
Hi @fbartho, this PR should still be good to review and add. I have used this code within an app using a fork and it works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for React Native's maxFontSizeMultiplier Text prop, which I need for some work that I'm doing.
ReactXP already has support for the allowFontScaling Text prop and these two props would be often used together so I feel like having them both available in ReactXP makes sense.