[0.63] Avoid eating clicks/taps into ScrollView when using physical keyboard…#668
Conversation
…facebook#30374) Summary: This is an extension of facebook#29798 which was reverted due to cases where the soft keyboard could not be dismissed. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - Avoid eating clicks/taps into ScrollView when using physical keyboard Pull Request resolved: facebook#30374 Test Plan: Validated with iOS simulator that taps on default ScrollView will dismiss soft keyboard and be eaten if open, but taps are not eaten when emulating a connected physical keyboard. Reviewed By: kacieb Differential Revision: D24935077 Pulled By: lyahdav fbshipit-source-id: 19d9cf64547e40a35f9363896e3abbdccb95b546
|
Not bothering to cherry-pick into master since this will be cherry-picked into 0.64 upstream. |
|
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Looking into CI issues |
|
@alloy 🤔 |
|
Hmm, unsure about that exclusion comment. When triggering it manually I ran into issues with Homebrew, which I was able to fix here, but I’m still somewhat naive about ADO. I guess it makes sense that the faulty installation is baked into the image and the fix needs to be ran for each run. |
|
I don’t know why this isn’t updated, but the build I triggered is now green https://dev.azure.com/ms/react-native/_build/results?buildId=126849&view=results 👍 |
… (facebook#30374)
Summary:
This is an extension of facebook#29798 which was reverted due to cases where the soft keyboard could not be dismissed.
Changelog
[General] [Fixed] - Avoid eating clicks/taps into ScrollView when using physical keyboard
Pull Request resolved: facebook#30374
Test Plan: Validated with iOS simulator that taps on default ScrollView will dismiss soft keyboard and be eaten if open, but taps are not eaten when emulating a connected physical keyboard.
Reviewed By: kacieb
Differential Revision: D24935077
Pulled By: lyahdav
fbshipit-source-id: 19d9cf64547e40a35f9363896e3abbdccb95b546
Please select one of the following
Microsoft Reviewers: Open in CodeFlow