This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Added building SparseSimulator without Cake#840
Merged
kuzminrobin merged 9 commits intofeature/sparse-simulatorfrom Oct 4, 2021
Merged
Added building SparseSimulator without Cake#840kuzminrobin merged 9 commits intofeature/sparse-simulatorfrom
kuzminrobin merged 9 commits intofeature/sparse-simulatorfrom
Conversation
kuzminrobin
requested review from
DmitryVasilevsky,
bettinaheim,
cgranade,
idavis and
swernli
kuzminrobin
commented
Sep 29, 2021
| Write-Host "On Linux build using Clang" | ||
| $CC = "clang-11" | ||
| $CXX = "clang++-11" | ||
| #$clangTidy = "-DCMAKE_CXX_CLANG_TIDY=clang-tidy-11" |
Contributor
Author
There was a problem hiding this comment.
I would like to preserve the clangTidy fragments for now.
kuzminrobin
commented
Sep 29, 2021
| # BUILD C# PART AND TESTS | ||
|
|
||
| dotnet build . --configuration $Env:BUILD_CONFIGURATION | ||
| # dotnet test . --configuration $Env:BUILD_CONFIGURATION |
Contributor
Author
There was a problem hiding this comment.
I would like to preserve this commented-out command for now.
kuzminrobin
commented
Sep 29, 2021
Comment on lines
+49
to
+54
| #if (Get-Command clang-tidy -ErrorAction SilentlyContinue) { | ||
| # # Only run clang-tidy if it's installed. This is because the package used by chocolatey on | ||
| # # the build pipeline doesn't include clang-tidy, so we allow skipping that there and let | ||
| # # the Linux build catch tidy issues. | ||
| # $clangTidy = "-DCMAKE_CXX_CLANG_TIDY=clang-tidy" | ||
| #} |
Contributor
Author
There was a problem hiding this comment.
I would like to preserve the clangTidy fragments for now.
kuzminrobin
force-pushed
the
kuzminrobin/sparseSimIntegr02
branch
from
c74d083 to
2157b81
Compare
kuzminrobin
force-pushed
the
kuzminrobin/sparseSimIntegr02
branch
from
7b9e35e to
15fa102
Compare
Contributor
Author
|
Please review. |
bootstrap.ps1
Outdated
| .\build.ps1 | ||
| Pop-Location | ||
|
|
||
| Write-Host "Build release flavor of the native simulator" |
Contributor
There was a problem hiding this comment.
I suggest you change it to "full state" rather than "native".
| # pushd Native\build\(Debug|Release) | ||
| Push-Location $BuildDir | ||
|
|
||
| $CmakeConfigCommand = "& cmake -G Ninja -D CMAKE_VERBOSE_MAKEFILE:BOOL=ON -D CMAKE_BUILD_TYPE=$Env:BUILD_CONFIGURATION -S ..\.. " # Without `-G Ninja` the compiler chosen is always `cl.exe`. |
Contributor
There was a problem hiding this comment.
Why does it start with '&'?
Contributor
Author
There was a problem hiding this comment.
Removed (I don't remember why it was starting with &).
DmitryVasilevsky
approved these changes
Oct 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also replaced
cl.execompiler on Win with Clang.It is not to
mainit is t o a feature branch.