Treat non-zero qubits on release as execution error#217
Merged
Conversation
swernli
requested review from
bamarsha,
billti,
idavis and
minestarks
as code owners
kuzminrobin
reviewed
Apr 26, 2023
kuzminrobin
approved these changes
Apr 26, 2023
Contributor
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
Approving to unblock, but I would recommend at least one more approval.
This change adds an execution error when qubits are released in a state other than the zero/ground state. This matches the behavior of the legacy simulator and helps with algorithm authoring and education scenarios. Fixes #201
swernli
force-pushed
the
swernli/release-qubits-zero-check
branch
from
b584749 to
dcf3663
Compare
bamarsha
approved these changes
Apr 27, 2023
billti
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an execution error when qubits are released in a state other than the zero/ground state. This matches the behavior of the legacy simulator and helps with algorithm authoring and education scenarios.
Fixes #201