Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Add an inline namespace for versioning #301

Closed
mingxwa wants to merge 2 commits into from
Closed

Add an inline namespace for versioning #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3668cfb
Add inline namespace
mingxwa May 31, 2025
b83f016
.
mingxwa May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/proxy/proxy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@

namespace pro {

inline namespace v4 {

namespace details {

struct applicable_traits { static constexpr bool applicable = true; };
Expand Down Expand Up @@ -2340,6 +2342,8 @@ struct weak_dispatch : D {
{ ___PRO_THROW(not_implemented{}); }
};

} // inline namespace v4

} // namespace pro

#if __STDC_HOSTED__ && __has_include(<format>)
Expand Down
2 changes: 1 addition & 1 deletion include/proxy/proxy.ixx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module;

export module proxy;
Copy link
Contributor

@SidneyCogdill SidneyCogdill May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest renaming the module name to proxy.v4;. This unblocks a future use case where both the module proxy.v4 and proxy.v5 can be built within the same project (assuming the user manually acquired the older Proxy 4, e.g. with git submodule, while an upstream library acquires Proxy 5 on its own).

The consumer would be using import proxy.v4; instead.


export namespace pro {
export namespace pro::v4 {
using pro::constraint_level;
using pro::proxiable_ptr_constraints;
using pro::facade_aware_overload_t;
Expand Down
4 changes: 4 additions & 0 deletions include/proxy/proxy_fmt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ later) are included before proxy_fmt.h.

namespace pro {

inline namespace v4 {

namespace details {

template <class CharT> struct fmt_format_overload_traits;
Expand Down Expand Up @@ -64,6 +66,8 @@ using fmt_wformat = typename FB::template add_convention<

} // namespace skills

} // inline namespace v4

} // namespace pro

namespace fmt {
Expand Down