This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Merged
Conversation
mingxwa
force-pushed
the
user/mingxwa/fix-proxy-view
branch
from
f26dbd5 to
1d3de9a
Compare
tian-lt
suggested changes
Feb 19, 2025
tian-lt
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I believe this is a design defect, and plan to ship it in 3.2.1 as a bug fix.
The semantics of
proxy_viewcan be reduced. Currently, one needs to useproxy<const F>to invoke any const conventions. With this change, users will have access to all the indirect conventions via aproxy_view<F>object as if it were aproxy<F>object.On the other hand,
basic_facade_builder::add_viewis removed due to incompatibility withsupport_view.Changes
observer_facade<F>to make it inherit all the indirect conventions fromF. Removed theconst Fspecializations.basic_facade_builder::add_view.details::proxy_view_dispatch. Changed the return type from a raw pointer to a new typeobserver_ptrthat is aware of the derecerenced types of the cv-ref qualified original pointer types.