This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Replace macro PRO_DEF_WEAK_DISPATCH with class template weak_dispatch#224
Merged
mingxwa merged 6 commits intomicrosoft:mainfrom Dec 26, 2024
Merged
Replace macro PRO_DEF_WEAK_DISPATCH with class template weak_dispatch#224mingxwa merged 6 commits intomicrosoft:mainfrom
PRO_DEF_WEAK_DISPATCH with class template weak_dispatch#224mingxwa merged 6 commits intomicrosoft:mainfrom
Conversation
tian-lt
approved these changes
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaced macro
PRO_DEF_WEAK_DISPATCHwith class templateweak_dispatch<D>. Specifically,not_implemented, inspired by NotImplementedException in .NET. However,not_implementedis not derived fromstd::logic_errororstd::runtime_errordue to freestanding limitations.weak_dispatch<D>will add a default implementation to an existing dispatch typeD. The default implementation simply throwsnot_implemented.[[deprecated]]attribute to types defined withPRO_DEF_WEAK_DISPATCH.bad_proxy_cast.Note that the return type of
weak_dispatch's default implementation isdetails::wildcard, which can syntactically be convertible to any type, while it will never be constructed.