This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Fix the std::in_place_type_t overload for SFINAE-unsafe facades#223
Merged
mingxwa merged 4 commits intomicrosoft:mainfrom Dec 23, 2024
Merged
Fix the std::in_place_type_t overload for SFINAE-unsafe facades#223mingxwa merged 4 commits intomicrosoft:mainfrom
std::in_place_type_t overload for SFINAE-unsafe facades#223mingxwa merged 4 commits intomicrosoft:mainfrom
Conversation
tian-lt
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change explicitly excludes
proxy(P&& ptr)from overload resolution ifPis a (possibly cv-qualified) specialization ofstd::in_place_type_t. It aligns with the implementation ofstd::anyin MSVC and libstdc++.Note that Clang 15 could not handle the situation where concepts are mixed with SFINAE. The test case will still fail in Clang 15. Since it is not trivial to work around, I removed support for Clang 15 from our pipeline and README for now. (See the previous CI build).
Resolves #222. Another unit test case was added accordingly.