This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Revise design of conversion_dispatch#212
Merged
mingxwa merged 4 commits intomicrosoft:mainfrom Dec 9, 2024
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 10 out of 25 changed files in this pull request and generated 2 suggestions.
Files not reviewed (15)
- proxy.h: Language not supported
- samples/basic_facade_builder/add_convention.cpp: Language not supported
- docs/conversion_dispatch.md: Evaluated as low risk
- docs/conversion_dispatch/accessor.md: Evaluated as low risk
- docs/conversion_dispatch/operator_call.md: Evaluated as low risk
- docs/PRO_DEF_FREE_DISPATCH.md: Evaluated as low risk
- docs/explicit_conversion_dispatch.md: Evaluated as low risk
- docs/explicit_conversion_dispatch/accessor.md: Evaluated as low risk
- docs/operator_dispatch/accessor.md: Evaluated as low risk
- docs/operator_dispatch.md: Evaluated as low risk
- README.md: Evaluated as low risk
- docs/specifications.md: Evaluated as low risk
- .github/workflows/bvt-gcc.yml: Evaluated as low risk
- docs/PRO_DEF_MEM_DISPATCH.md: Evaluated as low risk
- docs/PRO_DEF_FREE_AS_MEM_DISPATCH.md: Evaluated as low risk
Comments skipped due to low confidence (3)
docs/implicit_conversion_dispatch/accessor.md:14
- [nitpick] The phrase 'return-type-of' is used without being defined. Consider defining it or using a more standard term.
using accessor<F, C, Os>::operator return-type-of<Os>...;
docs/explicit_conversion_dispatch/operator_call.md:5
- The placeholder
/* see below */is not clear and should be replaced with the actual implementation or a more descriptive placeholder.
/* see below */ operator()(T&& value) noexcept;
docs/explicit_conversion_dispatch/operator_call.md:8
- [nitpick] The return description is ambiguous. It should clearly state what the function returns and under what conditions.
Returns a value that is implicitly convertible to any type `U` with expression `U{std::forward<T>(value)}` when `T` is explicitly convertible to type `U`.
tian-lt
suggested changes
Dec 9, 2024
tian-lt
approved these changes
Dec 9, 2024
guominrui
reviewed
Dec 10, 2024
| # Class `implicit_conversion_dispatch` | ||
|
|
||
| ```cpp | ||
| class explicit_conversion_dispatch; |
Member
There was a problem hiding this comment.
implicit_conversion_dispatch?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
conversion_dispatch. It was previously defined as a class template. After this change, it will be 2 separate classesexplicit_conversion_dispatchandimplicit_conversion_dispatch.proxywon't compile with GCC 11 or 12 anymore after this change. "README" and pipelines are updated accordingly.