Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Improve API design#128

Merged
mingxwa merged 3 commits intomicrosoft:mainfrom
mingxwa:user/mingxwa/friends
Jul 11, 2024
Merged

Improve API design#128
mingxwa merged 3 commits intomicrosoft:mainfrom
mingxwa:user/mingxwa/friends

Conversation

@mingxwa
Copy link
Contributor

@mingxwa mingxwa commented Jul 11, 2024

Changes

  • Moved function swap back to the definition of proxy, since overloading the global swap is no longer recommended after C++20.
  • Added friend function bool operator== similar with std::move_only_function.
  • Added a unit test case to cover the change.

@mingxwa mingxwa requested review from guominrui and tian-lt July 11, 2024 00:59
@mingxwa mingxwa self-assigned this Jul 11, 2024
@tian-lt
Copy link
Collaborator

tian-lt commented Jul 11, 2024

Add operator bool to align with std::move_only_function::operator bool?

@mingxwa
Copy link
Contributor Author

mingxwa commented Jul 11, 2024

Add operator bool to align with std::move_only_function::operator bool?

Make sense. Added.

@mingxwa mingxwa merged commit 0ad48da into microsoft:main Jul 11, 2024
@mingxwa mingxwa deleted the user/mingxwa/friends branch July 11, 2024 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants