Skip to content
This repository was archived by the owner on Jun 6, 2024. It is now read-only.

[Rest Server] Decompress large framework#3771

Merged
abuccts merged 3 commits intomasterfrom
xiongyf/decompress-framework
Oct 25, 2019
Merged

[Rest Server] Decompress large framework#3771
abuccts merged 3 commits intomasterfrom
xiongyf/decompress-framework

Conversation

@abuccts
Copy link
Copy Markdown
Member

@abuccts abuccts commented Oct 25, 2019

Decompress possible fields for large framework.

Reference: microsoft/frameworkcontroller#44

@abuccts abuccts requested a review from yqwang-ms October 25, 2019 05:25
Decompress possible fields for large framework.

Reference: microsoft/frameworkcontroller#44
@abuccts abuccts force-pushed the xiongyf/decompress-framework branch from 1f9ceb0 to b661353 Compare October 25, 2019 05:26
Fix lint.
yqwang-ms
yqwang-ms previously approved these changes Oct 25, 2019

const convertFrameworkSummary = (framework) => {
// check fields which may be compressed
if (framework.status.attemptStatus.taskRoleStatuses == null) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no need taskRoleStatuses for FrameworkSummary and job list? So you do not need to decompress it?

Copy link
Copy Markdown
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optmize job summary and job list

@yqwang-ms yqwang-ms self-requested a review October 25, 2019 06:34
@yqwang-ms yqwang-ms dismissed their stale review October 25, 2019 06:34

revoking review

Remove task status in framework summary.
Copy link
Copy Markdown
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@abuccts abuccts merged commit 85425cf into master Oct 25, 2019
@abuccts abuccts deleted the xiongyf/decompress-framework branch October 25, 2019 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants