Fix CVE-2025-54410: Upgrade docker/docker to v28.0.0#617
Merged
dlevy-msft-sql merged 2 commits intomainfrom Jan 20, 2026
Merged
Fix CVE-2025-54410: Upgrade docker/docker to v28.0.0#617dlevy-msft-sql merged 2 commits intomainfrom
dlevy-msft-sql merged 2 commits intomainfrom
Conversation
Contributor
|
Supersedes #606 |
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CVE-2025-54410 by upgrading Docker version
Fix CVE-2025-54410: Upgrade docker/docker to v28.0.0
Jan 20, 2026
There was a problem hiding this comment.
Pull request overview
This PR upgrades github.com/docker/docker from v27.3.1 to v28.0.0 to address CVE-2025-54410. The upgrade requires API migration changes due to Docker v28 relocating exec-related types from the types package to the container package.
Changes:
- Upgraded
github.com/docker/dockerdependency from v27.3.1 to v28.0.0 - Migrated exec API types:
types.ExecConfig→container.ExecOptionsandtypes.ExecStartCheck→container.ExecStartOptions - Removed obsolete import of
github.com/docker/docker/api/types
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updated docker/docker dependency version to v28.0.0 |
| go.sum | Updated checksums for docker/docker v28.0.0 |
| internal/container/controller.go | Migrated exec API types to container package and removed obsolete types import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlevy-msft-sql
approved these changes
Jan 20, 2026
shueybubbles
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
github.com/docker/dockerfrom v27.3.1 to v28.0.0 to address CVE-2025-54410.Changes
github.com/docker/dockerv27.3.1 → v28.0.0containerpackage:types.ExecConfig→container.ExecOptionstypes.ExecStartCheck→container.ExecStartOptionsUpdated
internal/container/controller.goaccordingly:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
cloud.google.com/update-job-proxy /update-job-proxy by/2d9c29d4361c1-V=full 92839b67d78da07e x64/pkg/tool/linux_amd64/vet /usr�� 91435/b545/_pkg_.a by/2d9c29d4361c16ac89eb51bf95fc1e9ac803cd16d5475f4492839b67d78da07e 91435/b545=> by/2d9c29d4361c1git soft/go-sqlcmd/crev-parse json 92839b67d78da07e /usr�� NHDB/SokYoUXIAbYUeOMgNHDB y fg by/4ddb2230c50b7/usr/bin/unpigz --log-format json 07e/log.json(dns block)/update-job-proxy /update-job-proxy DROP 2 git init�� fe486d056bb33ee9--depth=1 ps /bin/git bution %H %ct %D ub.com/.insteadOblob /usr/lib/git-cor185b4288413d2a0dd0806f78c90dde719829e5ae:go.mod remo�� REDACTED REDACTED e/git /etc/ssl/certs/f/usr/sbin/iptables sed 649421f6 e/git(dns block)does/tmp/go-build97691435/b546/install.test /tmp/go-build97691435/b546/install.test -test.testlogfile=/tmp/go-build97691435/b546/testlog.txt -test.paniconexit0 -test.timeout=5m0s /tmp/go-build97691435/b440/vet.cfg TOKEN"; }; f get TOKEN"; }; f get ux_amd64/vet --gdwarf-5 nternal/test p=/opt/hostedtoo--no-pager ux_amd64/vet -W bNeRgH2yD V3yW/i3Hp_KGhK1oveth9377e60 ux_amd64/vet 89b57c4ccb510665/opt/hostedtoolcache/go/1.24.11/x64/pkg/tool/linux_amd64/vet --gdwarf2 --64 ux_amd64/vet(dns block)go.googlesource.com/update-job-proxy /update-job-proxy by/2d9c29d4361c1-V=full 92839b67d78da07e x64/pkg/tool/linux_amd64/vet /usr�� 91435/b545/_pkg_.a by/2d9c29d4361c16ac89eb51bf95fc1e9ac803cd16d5475f4492839b67d78da07e 91435/b545=> by/2d9c29d4361c1git soft/go-sqlcmd/crev-parse json 92839b67d78da07e /usr�� NHDB/SokYoUXIAbYUeOMgNHDB y fg by/4ddb2230c50b7/usr/bin/unpigz --log-format json 07e/log.json(dns block)/update-job-proxy /update-job-proxy DROP 2 git init�� fe486d056bb33ee9--depth=1 ps /bin/git bution %H %ct %D ub.com/.insteadOblob /usr/lib/git-cor185b4288413d2a0dd0806f78c90dde719829e5ae:go.mod remo�� REDACTED REDACTED e/git /etc/ssl/certs/f/usr/sbin/iptables sed 649421f6 e/git(dns block)go.opentelemetry.io/update-job-proxy /update-job-proxy by/2d9c29d4361c1-V=full 92839b67d78da07e x64/pkg/tool/linux_amd64/vet /usr�� 91435/b545/_pkg_.a by/2d9c29d4361c16ac89eb51bf95fc1e9ac803cd16d5475f4492839b67d78da07e 91435/b545=> by/2d9c29d4361c1git soft/go-sqlcmd/crev-parse json 92839b67d78da07e /usr�� NHDB/SokYoUXIAbYUeOMgNHDB y fg by/4ddb2230c50b7/usr/bin/unpigz --log-format json 07e/log.json(dns block)/update-job-proxy /update-job-proxy DROP 2 git init�� fe486d056bb33ee9--depth=1 ps /bin/git bution %H %ct %D ub.com/.insteadOblob /usr/lib/git-cor185b4288413d2a0dd0806f78c90dde719829e5ae:go.mod remo�� REDACTED REDACTED e/git /etc/ssl/certs/f/usr/sbin/iptables sed 649421f6 e/git(dns block)google.golang.org/update-job-proxy /update-job-proxy by/2d9c29d4361c1-V=full 92839b67d78da07e x64/pkg/tool/linux_amd64/vet /usr�� 91435/b545/_pkg_.a by/2d9c29d4361c16ac89eb51bf95fc1e9ac803cd16d5475f4492839b67d78da07e 91435/b545=> by/2d9c29d4361c1git soft/go-sqlcmd/crev-parse json 92839b67d78da07e /usr�� NHDB/SokYoUXIAbYUeOMgNHDB y fg by/4ddb2230c50b7/usr/bin/unpigz --log-format json 07e/log.json(dns block)/update-job-proxy /update-job-proxy DROP 2 git init�� fe486d056bb33ee9--depth=1 ps /bin/git bution %H %ct %D ub.com/.insteadOblob /usr/lib/git-cor185b4288413d2a0dd0806f78c90dde719829e5ae:go.mod remo�� REDACTED REDACTED e/git /etc/ssl/certs/f/usr/sbin/iptables sed 649421f6 e/git(dns block)gopkg.in/update-job-proxy /update-job-proxy by/2d9c29d4361c1-V=full 92839b67d78da07e x64/pkg/tool/linux_amd64/vet /usr�� 91435/b545/_pkg_.a by/2d9c29d4361c16ac89eb51bf95fc1e9ac803cd16d5475f4492839b67d78da07e 91435/b545=> by/2d9c29d4361c1git soft/go-sqlcmd/crev-parse json 92839b67d78da07e /usr�� NHDB/SokYoUXIAbYUeOMgNHDB y fg by/4ddb2230c50b7/usr/bin/unpigz --log-format json 07e/log.json(dns block)/update-job-proxy /update-job-proxy DROP 2 git init�� fe486d056bb33ee9--depth=1 ps /bin/git bution %H %ct %D ub.com/.insteadOblob /usr/lib/git-cor185b4288413d2a0dd0806f78c90dde719829e5ae:go.mod remo�� REDACTED REDACTED e/git /etc/ssl/certs/f/usr/sbin/iptables sed 649421f6 e/git(dns block)gotest.tools/update-job-proxy /update-job-proxy by/2d9c29d4361c1-V=full 92839b67d78da07e x64/pkg/tool/linux_amd64/vet /usr�� 91435/b545/_pkg_.a by/2d9c29d4361c16ac89eb51bf95fc1e9ac803cd16d5475f4492839b67d78da07e 91435/b545=> by/2d9c29d4361c1git soft/go-sqlcmd/crev-parse json 92839b67d78da07e /usr�� NHDB/SokYoUXIAbYUeOMgNHDB y fg by/4ddb2230c50b7/usr/bin/unpigz --log-format json 07e/log.json(dns block)/update-job-proxy /update-job-proxy DROP 2 git init�� fe486d056bb33ee9--depth=1 ps /bin/git bution %H %ct %D ub.com/.insteadOblob /usr/lib/git-cor185b4288413d2a0dd0806f78c90dde719829e5ae:go.mod remo�� REDACTED REDACTED e/git /etc/ssl/certs/f/usr/sbin/iptables sed 649421f6 e/git(dns block)honnef.co/update-job-proxy /update-job-proxy by/2d9c29d4361c1-V=full 92839b67d78da07e x64/pkg/tool/linux_amd64/vet /usr�� 91435/b545/_pkg_.a by/2d9c29d4361c16ac89eb51bf95fc1e9ac803cd16d5475f4492839b67d78da07e 91435/b545=> by/2d9c29d4361c1git soft/go-sqlcmd/crev-parse json 92839b67d78da07e /usr�� NHDB/SokYoUXIAbYUeOMgNHDB y fg by/4ddb2230c50b7/usr/bin/unpigz --log-format json 07e/log.json(dns block)/update-job-proxy /update-job-proxy DROP 2 git init�� fe486d056bb33ee9--depth=1 ps /bin/git bution %H %ct %D ub.com/.insteadOblob /usr/lib/git-cor185b4288413d2a0dd0806f78c90dde719829e5ae:go.mod remo�� REDACTED REDACTED e/git /etc/ssl/certs/f/usr/sbin/iptables sed 649421f6 e/git(dns block)invalid.url/tmp/go-build97691435/b651/http.test /tmp/go-build97691435/b651/http.test -test.testlogfile=/tmp/go-build97691435/b651/testlog.txt -test.paniconexit0 -test.timeout=5m0s ctor�� 8436986/b510/_pk-s -trimpath x64/pkg/tool/lin-buildmode=exe -p m -lang=go1.24 x64/pkg/tool/lin/var/run/docker/runtime-runc/moby -o Ea4a/g42dwXYBc2b/run/containerd/io.containerd.runtime.v2.task/moby/ed0884991f65622309308b778c571/opt/hostedtoolcache/go/1.24.11/x64/pkg/tool/linux_amd64/vet .cfg ux_amd64/vet by/f486eb13e1411grep go.opentelemetry-q -lang=go1.22 ux_amd64/vet(dns block)someserver/tmp/go-build97691435/b699/sqlcmd.test /tmp/go-build97691435/b699/sqlcmd.test -test.testlogfile=/tmp/go-build97691435/b699/testlog.txt -test.paniconexit0 -test.timeout=5m0s go1.24.11 -c=4 -nolocalimports -importcfg /tmp/go-build97691435/b669/importcfg -pack /home/REDACTED/work/go-sqlcmd/go-sqlcmd/internal/output/formatter/base.go jFKYeWDdmPfF 8436��(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.