Skip to content

Fix evaluation of variables in included files#116

Merged
shueybubbles merged 5 commits intomainfrom
shueybubbles/114
Aug 16, 2022
Merged

Fix evaluation of variables in included files#116
shueybubbles merged 5 commits intomainfrom
shueybubbles/114

Conversation

@shueybubbles
Copy link
Collaborator

When using -i filename sqlcmd would incorrectly throw away the variable map if the file didn't have a GO statement at the end of it.
This change ensures the statements in the file get run.
It also updates the go-mssqldb dependency to the latest version.

Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apoorvdeshmukh
Copy link
Contributor

This PR resolves #114

Copy link
Collaborator

@stuartpa stuartpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shueybubbles shueybubbles merged commit 8d632fe into main Aug 16, 2022
@shueybubbles shueybubbles deleted the shueybubbles/114 branch August 16, 2022 15:01
@shueybubbles shueybubbles linked an issue Aug 25, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-v does not work when SQL file has comments

3 participants