Closed
Conversation
`edit` requires at least Rust 1.87, to support the unstable `MaybeUninit::write_filled` method. Update `Cargo.toml` to document this, so that there's a clear error message when attempting to build with an older toolchain. (I think eliminating the use of this method (and the `maybe_uninit_fill` unstable feeature) would allow the MSRV to be reduced to 1.86.)
Member
Author
|
I see #43 already does this and more. |
Member
|
Yeah, I think we should close this in favor of #43, in particular as it adds the license field. What do you think? |
Member
Author
|
Sure thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
editrequires at least Rust 1.87, to support the unstableMaybeUninit::write_filledmethod. UpdateCargo.tomlto document this, so that there's a clear error message when attempting to build with an older toolchain.(I think eliminating the use of this method (and the
maybe_uninit_fillunstable feeature) would allow the MSRV to be reduced to 1.86.)