Allow activating previous position in listing for file picker#440
Closed
theshubhamp wants to merge 2 commits intomicrosoft:mainfrom
Closed
Allow activating previous position in listing for file picker#440theshubhamp wants to merge 2 commits intomicrosoft:mainfrom
theshubhamp wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Selection position is preserved across directory traversal today. Activating at the same position after traversal doesn't work because the current implementation expects a "select" before "activate". Fixed by setting file_picker_pending_name in the Activated callback to allow users to activate a list item that was pre-selected from a previous screen. An alternative fix could be to reset the selection to default or the first node (i.e. `..`)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selection position is preserved across directory traversal today. Activating at the same position after traversal doesn't work because the current implementation expects a "select" before "activate".
Fixed by setting file_picker_pending_name in the Activated callback to allow users to activate a list item that was pre-selected from a previous screen.
Video:
https://github.com/user-attachments/assets/e2657c77-e66a-428f-a20f-91815daa58ba
An alternative fix could be to reset the selection to default or the first node (i.e.
..)#347