Conversation
|
Oh, so that's why I called |
| self.cursor_for_rendering = None; | ||
| self.set_selection(None); | ||
| self.search = None; |
There was a problem hiding this comment.
These two removed lines are old, from the initial import. I've since added dirty tracking in the ICU code which makes resetting self.search superfluous.
|
I didn't think of the performance issues of reflowing all the time. Probably what I get for trying to solve a simple issue on a phone. But wouldn't it possibly need to reflow if the margin size changes? My code wasn't performent, but did at least allow for that to happen. |
|
Closes microsoft#431 Co-authored-by: Leonard Hecker <leonard@hecker.io>
Closes #431
Not sure if there was something else planned, but basically reverting two small changes from #406 fixes the issue.
Well, only the
TextBuffer::edit_endone fixes the reported issue, but there was no point leaving the issue in the undo/redo code.