Merged
Conversation
DHowett
approved these changes
Jun 4, 2025
|
@lhecker While I think a longer timeout is preferable for key parsing anyway, note that the problem in issue #243 could be solved more reliably by removing the timeout altogether in the Line 533 in db1e813 By that I mean an infinite timeout, or at least something like a couple of seconds if you want to be really safe. Because you're assumedly not dealing with keypresses where you need to recognise a solitary escape. Everything you receive at that point should be a full escape sequence. |
Member
Author
|
Oh, that's a good idea! Thank you for that! |
Member
Author
|
I opened #424. |
Lou32Verbose
pushed a commit
to Lou32Verbose/edit
that referenced
this pull request
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #243
See: PowerShell/Win32-OpenSSH#2275