Avoid changing file picker selection when typing

[lhecker]

Closes #329

[DHowett]

I liked how it updated the picker but it makes sense that it shouldn't in this case

[lhecker]

I think we ideally need a more robust/elegant filepicker overall. Not sure how that would look though.

[ivanovkirilg]

OK, I don't understand this change, to be honest; but now I see this has introduced a regression (#347), I will ask my question.

@lhecker, in the issue #329 I pointed out the line that adds the /. As far as I could tell, that line does exactly and only this - appends a / to a matching directory path.
What is the reason to fix it like this, rather than just removing the line?

When I was writing the issue, I tried removing it - the rest of the file picker functionality (i.e. auto-selecting a matching file) seemed to be unaffected. I just didn't feel confident suggesting removing the functionality, in case you wanted to keep it for directories whose names don't conflict.

[lhecker]

As far as I could tell, that line does exactly and only this - appends a / to a matching directory path.

That line doesn't append a /, rather it updates the "File name:" field with whatever you clicked on.

What is the reason to fix it like this, rather than just removing the line?

The Windows file picker has exactly this behavior: When you click (or otherwise focus) a file in the file list, it'll update the "File name" field accordingly. So, the bug you found doesn't occur due to that line, but rather due to incorrect state tracking inside the list view UI component.