Fix consume_shortcut calls not checking for focus#298
Merged
Conversation
DHowett
approved these changes
May 27, 2025
| action = Action::Save; | ||
| } else if ctx.consume_shortcut(vk::N) { | ||
| action = Action::Discard; | ||
| if contains_focus { |
Member
There was a problem hiding this comment.
Why is this the responsibility of the caller of consume_shortcut? That means every context by default can consume a shortcut, even if it's not focused?
Member
Author
There was a problem hiding this comment.
Yes, I figured that this may sometimes be useful. Elsewhere I already mentioned that we should ideally modify consume_shortcut to do this for us. The only question is whether it checks whether the last node or the current (parent) node has focus. Sometimes you want one behavior sometimes the other.
DHowett
approved these changes
May 27, 2025
Lou32Verbose
pushed a commit
to Lou32Verbose/edit
that referenced
this pull request
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #202