Fix inconsistent ellipses in localization#282
Merged
lhecker merged 1 commit intomicrosoft:mainfrom May 31, 2025
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
FileNew ("..." was extraneous): does not open a prompt, just Untitled-*.txt.
ViewDocumentPicker ("..." was missing): opens a prompt.
EncodingReopen ("..." was missing): opens a prompt.
EncodingConvert ("..." was missing): opens a prompt.
ivanovkirilg
force-pushed
the
loc-correct-ellipses
branch
from
2d1424f to
b9e445e
Compare
Lou32Verbose
pushed a commit
to Lou32Verbose/edit
that referenced
this pull request
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering the convention of "Do Something" performing an action directly and "Do Something..." opening a prompt for additional input, this PR fixes the following inconsistencies for all present localizations:
FileNew"..." was extraneous - does not open a prompt, justUntitled-N.txt.ViewDocumentPicker"..." was missing, it opens a prompt. 1EncodingReopen"..." was missing, opens a prompt.EncodingConvert"..." was missing, opens a prompt.This PR will likely affect all open localization PRs 😕
Footnotes
"Document Picker" is a bit of an outlier as it is the name of the prompt itself, as opposed to an action preceded by a prompt like "Open File...". I can revert this one if there are objections. ↩