Add filtering & Use MIME aliases for the encoding picker#255
Add filtering & Use MIME aliases for the encoding picker#255lhecker merged 9 commits intomicrosoft:mainfrom
Conversation
As you may have already noticed, this should theoretically be fixed now in the main branch. We're releasing v1.1.0 with mostly bug fixes, including that one. It'll take a while to get to merge this PR (and all the others), due to the number of PRs and since we also maintain other projects. |
|
THIS IS SO COOL |
0bfb759 to
271264c
Compare
I have rebased this branch onto newer commits and can confirm that indeed the keyboard naviagation is fixed. |
|
After thinking about it over the last weeks, I came to the conclusion that showing MIME names by default would be the closes to what people would expect to see. It's now a lot more decluttered IMO. |
|
What do those MIME names look like? |
|
Here's a list: https://icu4c-demos.unicode.org/icu-bin/convexp?s=MIME |
|
notes from playing with it: matching 0 items accidentally displays all items; up and down and enter should let me select the item without tabbing to the list |
Closes microsoft#26 Co-authored-by: Maciej Bartczak <39600846+maciekbartczak@users.noreply.github.com> Co-authored-by: Leonard Hecker <leonard@hecker.io>
Closes #26
Demo:
2025-05-24.16-05-51.mp4
Two changes introduced in this pr:
fuzzy.rs(handles both regular names and aliases)I'm not sure how to implement (if there even should be) keyboard shortcut handling on the encoding picker screen - the only way to change focus between the search input and the table is to click with the mouse (or maybe I haven't found a way to change the focus using some shortcut that is already implemented). I do however think this is just how the application works, since I have observed the same mouse-only behaviour on the file save modal for example.
I'm open for feedback and happy to iterate further on this one.