Optimize std for size#241
Merged
lhecker merged 1 commit intomicrosoft:mainfrom May 23, 2025
yui-915:std-optimize-for-size
Merged
Optimize std for size#241lhecker merged 1 commit intomicrosoft:mainfrom yui-915:std-optimize-for-size
lhecker merged 1 commit intomicrosoft:mainfrom
yui-915:std-optimize-for-size
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
lhecker
approved these changes
May 23, 2025
Member
There was a problem hiding this comment.
Oh, so that's how you do it. Neat! This makes it almost 10% smaller!
I think most of the difference comes from the more compact sort algorithm. The downside of this PR is that this disables the performance optimizations for formatting decimals in fmt. So alternatively, we could also just write our own CS 101 quick-sort implementation. Hmm... a difficult decision to make.
Oh well! This project appears to be already a lot faster than other editors, so who cares. 😄 It's about the big picture. 🙂
Thank you for making this change!
diabloproject
pushed a commit
to diabloproject/edit
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
even smaller executables!