Skip to content

Complete Home key toggle functionality between line start and indentation #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhecker merged 3 commits into from
May 21, 2025
+7 −2
Merged

Complete Home key toggle functionality between line start and indentation #199

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7400416
feat(editor): Complete Home key toggle functionality
achaljhawar May 21, 2025
8d2f1da
Merge branch 'main' of https://github.com/microsoft/edit
achaljhawar May 21, 2025
57cb092
Fix Home cursor movement
lhecker May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/tui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2410,8 +2410,13 @@ impl<'a> Context<'a, '_> {
// If the line has some indentation and the user pressed Home,
// the first time it'll stop at the indentation. The second time
// they press it, it'll move to the true start of the line.
let indent_end = tb.indent_end_logical_pos();
if logical_after.x == 0 && logical_before > indent_end {
//
// If the cursor is already at the start of the line,
// we move it back to the end of the indentation.
if logical_after.x == 0
&& let indent_end = tb.indent_end_logical_pos()
&& (logical_before > indent_end || logical_before.x == 0)
Copy link
Member

@lhecker lhecker May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I was curious about it, I tried implementing it myself. The correct approach is checking for logical_before.x == 0.

I also made the optimization I described above, by moving the indent_end_logical_pos call into the let chain.

{
if modifiers == kbmod::SHIFT {
tb.selection_update_logical(indent_end);
} else {
Expand Down