Remove unsafe lifetime transmute in vt::Stream#178
Merged
lhecker merged 1 commit intomicrosoft:mainfrom May 22, 2025
Merged
Conversation
Meanwhile, make input::Stream an actual Iterator.
Contributor
Author
|
@microsoft-github-policy-service agree |
lhecker
approved these changes
May 22, 2025
Member
lhecker
left a comment
lhecker
left a comment
There was a problem hiding this comment.
Thank you for improving this! It's way better now.
DHowett
approved these changes
May 22, 2025
diabloproject
pushed a commit
to diabloproject/edit
that referenced
this pull request
May 29, 2025
A lending iterator ties the item lifetime to the borrow of `self`, so writing the lifetimes that way Just Works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lending iterator ties the item lifetime to the borrow of
self, so writing the lifetimes that way Just Works.I also make
input::Streaman actual Iterator, since it had no reason not to be.