Closed
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
@microsoft-github-policy-service agree |
Author
|
Oh ok somebody else did this... oops... #72 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrary to popular belief, Linux != Unix! And I assume the intention wasn't to support BSD either way, however the code is so close to supporting it that I think it justifies this PR anyways. The only problem with compiling is that
__errno_location()is a Linux-ism, whereas__errno()is the Unix method.For me, it does not cross compile from Linux to Unix because it tries to link against
-lexecinfo, which is missing. I didn't bother to try to fix this, I just set up a NetBSD VM to get this working (this is for a friend :P). Should you do this as well, note that program runs into a memory protection feature of NetBSD when it tries to callmprotect, and I had to run/usr/sbin/paxctl +m target/release/editto disable it for the program.Edited with the program itself; the lack of an LSP or anything definitely lead to some syntax issues, and I apologize.