Improve readability of consider_as_equal#134
Conversation
Maybe I am misreading or misunderstanding the code, but it feel clearly buggy...
DHowett
left a comment
There was a problem hiding this comment.
If anything, correctness aside, this seems clearer to me
|
@matklad I was reading reviews of edit (out of curiosity) and noticed that you disliked me changing the commit title. I genuinely apologize for that. If that ever happens again, please let me know. I thought that "fix typo" meant that it's not a bug, because I've never seen that used for anything other than spelling errors. This surprised me, because it did look like a bug to me. But I know you're very experienced, so I thought nothing further of it. In that context, "fix typo" and "improve readability" were synonyms so far to me. As you probably already know, this code is not listed as a module in |
|
Ah, I also misunderstood the intention behind rewording the commit message, sorry! I do use "typo" for bugs which are typos: the intention behind the code is clear, but isn't working because of simple typographical error, like a misplaced parentheses. |
Maybe I am misreading or misunderstanding the code, but it feels clearly buggy...