feat(assets): add a .desktop entry#107
Conversation
Add a .desktop entry for Edit. It expects edit.svg (also found in assets/) to be installed in one of the icon paths. Conformance to FreeDesktop.org's Desktop Entry Specification with desktop-file-validate(1). Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
| Keywords=text;txt;editor;note;notepad; | ||
| Keywords[zh_CN]=text;txt;editor;note;notepad;文字;文本;编辑器;笔记;记事本;wenzi;wenben;bianjiqi;biji;jishiben; |
There was a problem hiding this comment.
Helix only lists "text" and "editor" as keywords: https://github.com/helix-editor/helix/blob/3a6c9747b8de3350c38ba504916233d9d4c33c5c/contrib/Helix.desktop#L82
Should we do the same and only use this?
Keywords=text;editor
There was a problem hiding this comment.
Should we do the same and only use this?
This was done to align with KWrite, which in my opinion is quite easy to search for - being able to find it with "Windows-like" keywords is convenient.
There was a problem hiding this comment.
Edit and Notepad are two very different things, even on Windows.
I don't think people expect searching for "记事本" (Notepad) and getting a TUI editor...
There was a problem hiding this comment.
Edit and Notepad are two very different things, even on Windows. I don't think people expect searching for "记事本" (Notepad) and getting a TUI editor...
Sure, but notepad.exe and wordpad.exe being different things are really beside the point - both KDE and GNOME relies heavily on search-based navigation, and so does more traditional desktop environments (more experienced users are more likely to just use Alt-F2), same goes for WMs.
The second point I can agree with, but then this .desktop entry is useless - "why wouldn't they just run edit in a terminal?"
There was a problem hiding this comment.
And, to clarify, I do not expect everyone to install or package this .desktop entry, it's here as a reference.
There was a problem hiding this comment.
We've discussed this and would currently prefer just text;editor like Helix uses. Could you make this change? If we ever take on more complex features (like VS Code) we could extend the list.
Closes #107 Co-authored-by: Mingcong Bai <jeffbai@aosc.io>
|
Thanks! We weren't able to push a quick fix to your pr, so we credited you in #420 :) |
Closes microsoft#107 Co-authored-by: Mingcong Bai <jeffbai@aosc.io>
5 participants
Add a .desktop entry for Edit. It expects edit.svg (also found in assets/) to be installed in one of the icon paths.
Conformance to FreeDesktop.org's Desktop Entry Specification with desktop-file-validate(1).