`Close Editor` exits the application if there are no other buffers to close.

[zcobol]

• open edit
• select File then Close Editor
• select File and Close Editor again

On launch:

After closing the editor:

Close Editor should give a warning only. Exit should terminate the application.

[DHowett]

I feel like we should probably hide or disable that menu item completely if there are no open editors.

[lhecker]

VS Code hooks Ctrl+Q by default. To make it easier for such people to exit the editor, I made this change intentionally. Now they can just press Ctrl+W twice and it'll exit.

[GitMensch]

Why should you run edit within vscode?

Of course I do use vim in there personally, but would consider that a more exotic setup and keep "close editor" and "quit" separately.

[lhecker]

I've given a (weak) reason why we may want to keep it. Can you name a reason why it should be removed?
I'm not super serious about keeping this behavior, to be clear, but I personally have come to like it a bit.

[GitMensch]

because sometimes you press too long or double CTRL+W and don't want your program to be closed - because if you want that you go with CTRL+Q directly (I obviously also care much more about the ASCII fallback for search [before you ask ;-) I don't plan to work on "edit" myself, currently])

[stormcrash486]

Is there a reason it's called Close Editor and not Close File to be consistent with the other file operations? I know some apps like web browsers will close the program when doing a Ctrl-W on the last tab or an empty window so there is some precedent for not disabling the menu option when no documents are open.

[lhecker]

I copied the string from VS Code. I didn't give it too big of a thought, but I did wonder about it as well. We can rename it to "Close File" later. (If we made that change now it would conflict with several other PRs.)

[ivanovkirilg]

My 2 cents:
I rather frequently find myself opening a number of files, browsing them, then deciding I'm done.
When I'm done, I spam Ctrl+W until they are all gone.
Then I may open just one of them (e.g. where I have determined a change is needed) or something else. In other cases I may just close the program.

I have not used edit enough yet to notice this behavior, but I assume it would interfere with this habit.

VS Code also has 'close all open editors', I don't think that command is available in edit?

[lhecker]

That's a good point. Holding Ctrl+W to close all files is also something I'd see myself and others doing. Thanks for bringing this up. But let's keep it as it is for now and consider changing this at a later time.

[lhecker]

We decided that we'd like to keep the current behavior. It also matches the behavior of most (all?) browsers which also close when you close the last tab. Of course, and editor is not a browser, but there's small, tangible benefits to the current behavior and we should wait a bit longer to see whether it's a problem for more people.

[GitMensch]

Either close this issue now (preferably by implementing a "close all editors" menu option with a shortcut), or make it configurable later...

https://xkcd.com/1172

Changing a behaviour like this after some versions would be bad - and the "close all editors" was also requested :-)

[ivanovkirilg]

I wouldn't mind trying my hand at implementing Close All Editors, @lhecker would you like to go this route and assign this to me?

[lhecker]

Not entirely sure if we should add it just yet. As GitMensch noted, anything we add will be something people come to rely on. This applies to Ctrl+W as much as the "Close All Editors" menu item.

That said, I do think we should add it eventually. It's just that I would put it exclusively into the command palette. I would accept a PR though that adds support for key chord sequences, so that we can add support for Ctrl+K, Ctrl+W eventually - the same keybinding that VS Code uses for this.