A bit awkward to change drives on Windows in open/save dialog

[The-MAZZTer]

I would expect to be able to navigate up using ".." ultimately to a list of drives to select from, but it stops at the root of the current drive.

I did discover you can select the File name field and type in a folder name to jump to another drive.

My concern is this may not be intuitive for everyone. For example, navigating up to a drive list was the first thing I tried, followed by selecting the Folder: field (which is, in the native Windows dialogs, another place you can type to jump between folders and drives). Only a bit later did I think to try typing in the filename field to change folders (which I also know from the native Windows dialogs).

I would suggest on Windows adding a drive list accessible via ".." at a drive root to make it easier to discover a way to change drives.

Another option would be to add a separate UI element to change drives, but since this would be a Windows-only feature I don't think that would make sense.

[lhecker]

Ah, right. I forgot about that. 🙈 The relevant code is here:

edit/src/bin/edit/draw_filepicker.rs

Lines 197 to 258 in d832058

	// Returns Some(path) if the path refers to a file.
	fn draw_file_picker_update_path(state: &mut State) -> Option<PathBuf> {
	let path = state.file_picker_pending_dir.as_path();
	let path = path.join(&state.file_picker_pending_name);
	let path = path::normalize(&path);
	let (dir, name) = if path.is_dir() {
	(path.as_path(), PathBuf::new())
	} else {
	let dir = path.parent().unwrap_or(&path);
	let name = path.file_name().map_or(Default::default(), |s| s.into());
	(dir, name)
	};
	if dir != state.file_picker_pending_dir.as_path() {
	state.file_picker_pending_dir = DisplayablePathBuf::new(dir.to_path_buf());
	state.file_picker_entries = None;
	}
	state.file_picker_pending_name = name;
	if state.file_picker_pending_name.as_os_str().is_empty() { None } else { Some(path) }
	}
	fn draw_dialog_saveas_refresh_files(state: &mut State) {
	let dir = state.file_picker_pending_dir.as_path();
	let mut files = Vec::new();
	if dir.parent().is_some() {
	files.push(DisplayablePathBuf::from(".."));
	}
	if let Ok(iter) = fs::read_dir(dir) {
	for entry in iter.flatten() {
	if let Ok(metadata) = entry.metadata() {
	let mut name = entry.file_name();
	if metadata.is_dir()
	|| (metadata.is_symlink()
	&& fs::metadata(entry.path()).is_ok_and(|m| m.is_dir()))
	{
	name.push("/");
	}
	files.push(DisplayablePathBuf::from(name));
	}
	}
	}
	// Sort directories first, then by name, case-insensitive.
	let off = files.len().saturating_sub(1);
	files[off..].sort_by(|a, b| {
	let a = a.as_bytes();
	let b = b.as_bytes();
	let a_is_dir = a.last() == Some(&b'/');
	let b_is_dir = b.last() == Some(&b'/');
	match b_is_dir.cmp(&a_is_dir) {
	Ordering::Equal => icu::compare_strings(a, b),
	other => other,
	}
	});
	state.file_picker_entries = Some(files);
	}