fix: add --force flag to uv cache clean to prevent deadlock#63
Merged
Conversation
The `amplifier reset` command was hanging indefinitely while cleaning the UV cache because `uv cache clean` without `--force` waits for an exclusive lock on the cache directory. Since amplifier itself runs as a uv-installed tool, the cache is always "in use" when running `amplifier reset`, causing an unresolvable deadlock. Changes: - Added `--force` flag to bypass the in-use check (per uv's docs) - Added a 60-second timeout as a safeguard - Added handling for `subprocess.TimeoutExpired` exception - Updated docstring to explain why `--force` is required 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amplifier resethanging indefinitely when cleaning UV cache--forceflag touv cache cleancommand to bypass exclusive lock checkProblem
The
amplifier resetcommand was hanging indefinitely while cleaning the UV cache. The root cause:uv cache cleanwithout--forcewaits for an exclusive lock on the cache directoryamplifier resetSolution
Per uv's documentation, the
--forceflag bypasses the in-use check. This is the intended solution for this scenario.Additional safeguards added:
subprocess.TimeoutExpiredexception--forceis requiredTest plan
amplifier resetno longer hangs--dry-runflag shows correct commandamplifier reset🤖 Generated with Amplifier