Default.rd.xml fixes from VS 2017#950
Closed
brody4hire wants to merge 1 commit intomicrosoft:masterfrom
Closed
Conversation
- update go.microsoft.com link to https - fix Namespace Serialize attribute name in comments Co-authored-by: Microsoft team <info@microsoft.com> Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
2 tasks
janpio
pushed a commit
to apache/cordova-windows
that referenced
this pull request
Sep 2, 2018
…ies/Default.rd.xml (#286) ### Original issue <https://issues.apache.org/jira/browse/CB-14225> ### Platforms affected Windows ### What does this PR do? - Fix sample Namespace Serialize attribute in `template/Properties/Default.rd.xml`, according to `Default.rd.xml` in C# UWP project generated by Visual Studio 2017 I also raised <microsoft/Windows-universal-samples#950> to apply a similar fix there. Also related: - #284 - fix license text & add link to `template/Properties/Default.rd.xml` (as reported in <https://issues.apache.org/jira/browse/CB-14224>) - <microsoft/Windows-universal-samples#949> - fix license txt (related to but not part of #284) ### What testing has been done on this change? - Visual inspection - check diff ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - ~~Added automated test coverage as appropriate for this change.~~
oldnewthing
force-pushed
the
master
branch
6 times, most recently
from
2239d7f to
9bf6501
Compare
Member
|
You forgot the vb version. Fixed and pulled for next refresh. Thanks. |
oldnewthing
added a commit
that referenced
this pull request
Mar 25, 2020
* 360VideoPlayback: Align configurations, reset shader between stages #791 #942 * Clipboard: Add history and roaming scenarios, improve delay-rendering, clipboard change reporting, error-handling. * CustomSerialDeviceAccess: Fix RequestToSendXOnXOff #1085 * Holographic samples support HoloLens 2 device and emulator * HolographicFaceTracking: Fix comment about NV12 #834 * HolographicVoiceInput: Fix release build * PlayReady: Don't create container twice #1159 * RadioManager: Clarify require capabilities #1165 * SpeechRecognitionAndSynthesis: Clarify which scenarios require internet access #725, Update permission links #1002 * UserActivity: Fix protocol navigation #1176 * XamlMasterDetail: Fix navigation problems #344 #345 * SharedContent: Default.rd.xml fixes #950 * Miscellaneous typos: AdvancedCasting #1006, AudioCreation #1006, BluetoothAdvertisement #898, BluetoothRfcommChat #1139, Json #404, Nfc #1039, XamlBind #1169 #1182 * Add missing Line Display sample to TOC #704 * All C++ samples now build in both VS2017 and VS2019. * All C++/WinRT samples upgraded to C++/WinRT 2.0 #1179 * New: Clipboard (C++/WinRT), JapanesePhoneticAnalysis (C++/WinRT) * Archived: Advertising, CallerId, Clipboard (C++/CX and VB), CommunicationBlockAndFilter, PhoneCall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quickly marked "Microsoft team info@microsoft.com" as the primary author. I would be happy to change it if necessary.