Set config to useHttpPath=true#301
Merged
jeschu1 merged 1 commit intomicrosoft:masterfrom Oct 1, 2018
Merged
Conversation
jeschu1
force-pushed
the
add_config
branch
2 times, most recently
from
38a6d00 to
2ef550a
Compare
sanoursa
approved these changes
Sep 26, 2018
Contributor
sanoursa
left a comment
sanoursa
left a comment
There was a problem hiding this comment.
Looks good, with some minor cleanup.
GVFS/GVFS.Common/Git/GitProcess.cs
Outdated
| { | ||
| Result gitCredentialOutput = this.InvokeGitAgainstDotGitFolder( | ||
| "credential fill", | ||
| "-c credential.useHttpPath=true credential fill", |
Contributor
There was a problem hiding this comment.
Since we have to set this config value both here and in GVFSVerb, please use a constant to make sure they always agree with each other.
wilbaker
approved these changes
Sep 26, 2018
Hostname is no longer sufficent for VSTS authentication. VSTS now requires dev.azure.com/account to determine the tenant. By setting useHttpPath, credential managers will get the path which contains the account as the first parameter. They can then use this information for auth appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hostname is no longer sufficient for VSTS authentication. VSTS now requires dev.azure.com/account to determine the tenant.
By setting useHttpPath, credential managers will get the path which contains the account as the first parameter. They can then use this information for auth appropriately.
Please note this may require a reauth of the repository once as it move the token storage to include path.