Skip to content

Conversation

@jakebailey
Copy link
Member

Fixup for after #52474.

@jakebailey jakebailey requested a review from sandersn February 16, 2023 23:33
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 16, 2023
@jakebailey
Copy link
Member Author

jakebailey commented Feb 16, 2023

Unless the intent was to show this error; in which case I will revert the change to the test and just accept the baseline:

diff --git a/./tests/baselines/reference/overloadTag2.errors.txt b/./tests/baselines/local/overloadTag2.errors.txt
index d6faad296c..e3b54ad441 100644
--- a/./tests/baselines/reference/overloadTag2.errors.txt
+++ b/./tests/baselines/local/overloadTag2.errors.txt
@@ -1,8 +1,9 @@
+tests/cases/conformance/jsdoc/overloadTag2.js(14,9): error TS2394: This overload signature is not compatible with its implementation signature.
 tests/cases/conformance/jsdoc/overloadTag2.js(25,20): error TS7006: Parameter 'b' implicitly has an 'any' type.
 tests/cases/conformance/jsdoc/overloadTag2.js(30,9): error TS2554: Expected 1-2 arguments, but got 0.
 
 
-==== tests/cases/conformance/jsdoc/overloadTag2.js (2 errors) ====
+==== tests/cases/conformance/jsdoc/overloadTag2.js (3 errors) ====
     export class Foo {
         #a = true ? 1 : "1"
         #b
@@ -17,6 +18,9 @@ tests/cases/conformance/jsdoc/overloadTag2.js(30,9): error TS2554: Expected 1-2
         /**
          * @constructor
          * @overload
+            ~~~~~~~~
+!!! error TS2394: This overload signature is not compatible with its implementation signature.
+!!! related TS2750 tests/cases/conformance/jsdoc/overloadTag2.js:25:5: The implementation signature is declared here.
          * @param {number} a
          */
         /**

@sandersn
Copy link
Member

The intent was to show the error, since there was some discussion about whether it was a good idea, and we decided on Yes.

@jakebailey
Copy link
Member Author

Alright, redoing!

@jakebailey jakebailey merged commit 3980b5b into microsoft:main Feb 16, 2023
@jakebailey jakebailey deleted the fix-overloadTag2 branch February 16, 2023 23:57
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants