Add preceding semicolon on await insertion when parentheses are included #34627
Conversation
andrewbranch
force-pushed
the
bug/33522
branch
from
eba0325 to
c15b40e
Compare
andrewbranch
force-pushed
the
bug/33522
branch
from
c15b40e to
d743f0d
Compare
| index: 0, | ||
| newFileContent: | ||
| `async function fn(a: Promise<{ x: string }>) { | ||
| console.log(3) |
There was a problem hiding this comment.
Shouldn't this have ; after console.log and on that line instead of next line ?
There was a problem hiding this comment.
This is actually the typical preferred style for non-semicoloners. See https://standardjs.com/rules.html#semicolons
There was a problem hiding this comment.
/cc @orta to confirm people actually do this?
There was a problem hiding this comment.
Prettier does it this way, to which I give more credence than StandardJS anyway. I feel good about keeping it.
There was a problem hiding this comment.
Yep, confirming, this is what I'm used to
| sourceFile, | ||
| insertionSite.parent.expression, | ||
| createParen(createAwait(insertionSite.parent.expression))); | ||
| insertLeadingSemicolonIfNeeded(changeTracker, insertionSite.parent.expression, sourceFile); |
There was a problem hiding this comment.
| insertLeadingSemicolonIfNeeded(changeTracker, insertionSite.parent.expression, sourceFile); | |
| insertLeadingSemicolonIfNeeded(changeTracker, insertionSite.parent.expression, sourceFile); |
There was a problem hiding this comment.
The current indentation is correct (the preceding three lines are arguments to replaceNode; this is not)
5 participants
Fixes #33522