Autocompletion doesn't suggest global variables exposed from dependent packages (regression)

[falsandtru]

Hiding global variables from autocomplition is very annoying because other candidates make unnecessary import statements (We can't use autocompletion without making them).

Search Terms:

Code

1. clone https://github.com/falsandtru/spica
2. run npm i
3. open index.ts
4. type asse
5. suggests 2 candidates of assert but doesn't include global one.

Global assert is defined here: https://github.com/falsandtru/spica/blob/master/global.test.d.ts#L6

Expected behavior:

Suggests global assert and packaged assert.

Actual behavior:

Suggests packaged assert twice.

Playground Link:

Related Issues:

[falsandtru]

This bug make user experience obviously worse. This must be fixed before being distributed by the next stable release 3.6.

[falsandtru]

@orta Can you fix? This bug is very stressful.

[orta]

You're welcome to take a look at fixing it if you'd like to see it get merged faster @falsandtru - otherwise I will get to it for 3.7.0

[falsandtru]

I think this problem will appear on many projects and prevent their development if you distribute this bug via 3.6; 3.7 is too late.

[orta]

I think this is fixed in 3.7 by @andrewbranch with #32517 - on second thoughts, I don't think it is

[andrewbranch]

It looks like this is a bug specific to redeclaring a module as a global.

[orta]

Looks like it's the export as namespace assert; in power-assert which triggers this.

I've been struggling to get a repro in a fourslash test though, but I do have a minimal repro environment which should be:

// @Filename: /myAssert.d.ts
////declare function assert(value:any, message?:string):void;
////export = assert;
////export as namespace assert;

// @Filename: /ambient.d.ts
////import assert from './myAssert';
////
////type Assert = typeof assert;
////
////declare global {
////  const assert: Assert;
////}

// @Filename: /index.ts
/////// <reference path="./ambient.d.ts" />
////asser/**/;

[andrewbranch]

@orta make sure you set // @esModuleInterop: true, // @target: esnext, and pass preferences: { includeCompletionsForModuleExports: true, includeInsertTextCompletions: true } to the verify call.