This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Use latest Azure Quantum .NET SDK and Newtonsoft.Json packages#588
Merged
Use latest Azure Quantum .NET SDK and Newtonsoft.Json packages#588
Conversation
cgranade
reviewed
Jan 21, 2022
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Newtonsoft.Json" Version="12.0.3" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.1" /> |
Contributor
There was a problem hiding this comment.
We've had issues before with subtle changes in serialization breaking electron interop. Have you run this sample manually to confirm that the GUI works correctly?
Member
Author
There was a problem hiding this comment.
I did. I ran them again and this time compared the results against main.
I got the same results.
I posted the screenshots in the description. Please double-check they look alright.
cgranade
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Azure.Quantum.Clientfrom theQ# runtimerepo has been updated to use the latestNewtonsoft.Jsonpackage13.0.1.Some samples had references directly to
Azure.Quantum.Clientor theMicrosoft.Quantum.Simulators(which usesAzure.Quantum.Client) and they were also referencing to an older version ofNewtonsoft.Json, causing a build failure.This PR fixes the samples by bumping them to the latest
Newtonsoft.Jsonand unblocks microsoft/qsharp-runtime#904Manual tests of affected projects:
MolecularHydrogenGUI
LithiumHydrideGUI
H2SimulationGUI
