This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Fix false contract assumption encountered on System.Decimal.op_Explicit#203
Merged
SergeyTeplyakov merged 1 commit intomicrosoft:masterfrom Aug 12, 2015
Merged
Conversation
Contributor
|
Two questions:
I'm not sure about second one, maybe it can break something, but first one seems very reasonable for me. |
Contributor
Author
|
Contributor
|
Could you please update the PR to address the first comment? |
b05a9b4 to
8ba03ed
Compare
Contributor
Author
|
Sorry about the delay, it's been nighttime here. Updated. |
SergeyTeplyakov
added a commit
that referenced
this pull request
Aug 12, 2015
Fix false contract assumption encountered on System.Decimal.op_Explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this has any actual effect on the release builds, but it stopped me getting an exception here when debugging.
op_Explicit,op_Implicit, andop_UnaryNegationall have just one argument, so the assumption that all operations forSystem.Decimalhave two or more arguments is incorrect.