do not warn if polling interval is undefined#161
Merged
a-b-r-o-w-n merged 2 commits intomicrosoft:masterfrom Feb 25, 2019
Merged
do not warn if polling interval is undefined#161a-b-r-o-w-n merged 2 commits intomicrosoft:masterfrom
a-b-r-o-w-n merged 2 commits intomicrosoft:masterfrom
Conversation
orgads
reviewed
Feb 24, 2019
|
|
||
| if (parsedPollingInterval < POLLING_INTERVAL_LOWER_BOUND) { | ||
| console.warn(`DirectLineJS: provided pollingInterval (${ options.pollingInterval }) is under lower bound (200ms), using default of 1000ms`); | ||
| if (typeof options.pollingInterval !== 'undefined') { |
Contributor
There was a problem hiding this comment.
Why typeof, and not just options.pollingInterval === undefined?
Contributor
There was a problem hiding this comment.
This is a JS idiom used because in some cases the identifier being check may not have been initialized yet. That's not the case here, but it doesn't hurt using typeof.
a-b-r-o-w-n
approved these changes
Feb 25, 2019
a-b-r-o-w-n
changed the title
a-b-r-o-w-n
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
After our recent pull #157, a warning message will pop up if
pollingActivitydoes not fall into our acceptable range and being overridden.The warning message should not show up if the
pollingActivityisundefined. This is because we should assume if the user provideundefinedfor an options, they prefer default value. Thus, the warning is redundant in this case.This PR is to suppress the warning message for
undefinedcase.Changelog
Fixed
pollingIntervalisundefined, by @compulim in PR #161